Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Hyperparameter the GetGroups call with aggregate values #10175

Open
wants to merge 5 commits into
base: feature/row-grouping
Choose a base branch
from
Open

feat: Add Hyperparameter the GetGroups call with aggregate values #10175

wants to merge 5 commits into from

Conversation

AmanuelAaron
Copy link
Contributor

@AmanuelAaron AmanuelAaron commented Oct 31, 2024 •
edited
Loading

Ticket

ET-840

Description

Add hyperparameters to GetGroups

Test Plan

integration tests

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 31, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 31, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit c142e80
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6723decf5fba6c00080231c0
😎 Deploy Preview https://deploy-preview-10175--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AmanuelAaron AmanuelAaron changed the base branch from main to feature/row-grouping October 31, 2024 19:48
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.63%. Comparing base (9943bac) to head (4d30d9f).

Additional details and impacted files 
@@                   Coverage Diff                    @@
##           feature/row-grouping   #10175      +/-   ##
========================================================
+ Coverage                 54.62%   54.63%   +0.01%     
========================================================
  Files                      1260     1260              
  Lines                    157696   157723      +27     
  Branches                   3631     3631              
========================================================
+ Hits                      86141    86173      +32     
+ Misses                    71421    71416       -5     
  Partials                    134      134
Flag Coverage Δ
backend 45.47% <100.00%> (+0.03%) ⬆️
harness 72.74% <ø> (ø)
web 54.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/api_runs.go 68.86% <100.00%> (+1.02%) ⬆️

... and 6 files with indirect coverage changes

@AmanuelAaron AmanuelAaron changed the title Aaron amanuel/group hparam feat: Add Hyperparameter the GetGroups call with aggregate values Nov 4, 2024
@AmanuelAaron AmanuelAaron marked this pull request as ready for review November 4, 2024 18:00
@AmanuelAaron AmanuelAaron requested review from a team as code owners November 4, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesse-amano-hpe jesse-amano-hpe jesse-amano-hpe approved these changes

@mackrorysd mackrorysd Awaiting requested review from mackrorysd

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmanuelAaron @jesse-amano-hpe